sanpwc commented on code in PR #2679:
URL: https://github.com/apache/ignite-3/pull/2679#discussion_r1362487349
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2606,6 +2629,7 @@ private CompletableFuture<ReplicaResult>
processSingleEntryAction(ReadWriteSingl
return takeLocksForDelete(row, rowId, txId)
.thenCompose(ignored ->
validateOperationAgainstSchema(request.transactionId()))
+ .thenCompose(catalogVersion -> checkCleanup(rowId,
catalogVersion))
Review Comment:
> Is there any benefit from doing this?
Minor and in rare cases whe operation tiriggers the cleanup itself.
Feel free to use your original solution.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2606,6 +2629,7 @@ private CompletableFuture<ReplicaResult>
processSingleEntryAction(ReadWriteSingl
return takeLocksForDelete(row, rowId, txId)
.thenCompose(ignored ->
validateOperationAgainstSchema(request.transactionId()))
+ .thenCompose(catalogVersion -> checkCleanup(rowId,
catalogVersion))
Review Comment:
> Is there any benefit from doing this?
Minor and in rare cases whe operation tiriggers the cleanup itself.
Feel free to use your original solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
