korlov42 commented on code in PR #2671:
URL: https://github.com/apache/ignite-3/pull/2671#discussion_r1363688794
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/ExpressionFactoryImpl.java:
##########
@@ -20,18 +20,19 @@
import static org.apache.ignite.internal.util.CollectionUtils.nullOrEmpty;
import com.github.benmanes.caffeine.cache.Caffeine;
+import com.google.common.collect.ImmutableList;
Review Comment:
we should avoid using guava library
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/ExpressionFactoryImpl.java:
##########
@@ -376,17 +388,45 @@ private void expandBounds(
List<RexNode> curLower,
List<RexNode> curUpper,
boolean lowerInclude,
- boolean upperInclude
+ boolean upperInclude,
+ boolean containNull
Review Comment:
as far as I an see, `containNull` is never `false`. Thus, why do we need
this flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
