vldpyatkov commented on code in PR #2604:
URL: https://github.com/apache/ignite-3/pull/2604#discussion_r1364096351
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java:
##########
@@ -313,17 +307,23 @@ private void loadLeasesBusyAsync(long recoveryRevision) {
* @param causalityToken Causality token.
* @param lease Lease to check on expiration.
*/
- private void firePrimaryReplicaExpiredEventIfNeed(long causalityToken,
Lease lease) {
- ReplicationGroupId grpId = lease.replicationGroupId();
+ private void firePrimaryReplicaExpiredEventIfNeeded(ReplicationGroupId
grpId, long causalityToken, @Nullable Lease lease) {
Review Comment:
Add grpId in parameters declaration in the method javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]