korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1368453761


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ExchangeExecutionTest.java:
##########
@@ -495,8 +497,13 @@ private RewindableAsyncRoot<Object[], Object[]> 
createRootFragment(
         ExchangeService exchangeService = 
exchangeServices.computeIfAbsent(localNode.name(), name ->
                 createExchangeService(taskExecutor, 
serviceFactory.forNode(localNode.name()), mailboxRegistry));
 
+        RowSchema schema = RowSchema.builder()

Review Comment:
   I would say, TestDataProvider depends on that schema. Thus, I moved schema 
definition to a static field and left a comment that all data providers created 
within this test class must conform to that schema



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to