korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370011800
##########
modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleBuilder.java:
##########
@@ -82,11 +82,24 @@ public BinaryTupleBuilder(int numElements) {
* @param totalValueSize Total estimated length of non-NULL values, -1 if
not known.
*/
public BinaryTupleBuilder(int numElements, int totalValueSize) {
+ this(numElements, totalValueSize, true);
+ }
+
+ /**
+ * Creates a builder.
+ *
+ * @param numElements Number of tuple elements.
+ * @param totalValueSize Total estimated length of non-NULL values, -1 if
not known.
+ * @param exactEstimate Whether the total size is exact estimate or
approximate. The
+ * difference here is with exact estimate allocation will be optimal,
while with
+ * approximate estimate some excess allocation is possible.
+ */
+ public BinaryTupleBuilder(int numElements, int totalValueSize, boolean
exactEstimate) {
Review Comment:
Please read
[these](https://github.com/apache/ignite-3/pull/2728#discussion_r1369686009)
[two](https://github.com/apache/ignite-3/pull/2728#discussion_r1369698209)
replies. If the reason of adding this flag still remains not clear, please
don't hesitate to ask follow up questions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
