korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1371186032
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##########
@@ -73,6 +97,88 @@ public static BinaryTuplePrefix fromBinaryTuple(BinaryTuple
tuple) {
return new BinaryTuplePrefix(tuple.elementCount(), prefixBuffer);
}
+ private static BinaryTuplePrefix expandTuple(int numElements, BinaryTuple
tuple) {
+ assert numElements > tuple.elementCount();
+
+ if (tuple.elementCount() == 0) {
+ return new BinaryTuplePrefix(
+ numElements, new BinaryTuplePrefixBuilder(0, numElements,
0).build()
+ );
+ }
+
+ int[] dataBeginOffsetHolder = new int[1];
+ int[] dataEndOffsetHolder = new int[1];
+
+ tuple.fetch(0, (index, begin, end) -> dataBeginOffsetHolder[0] =
begin);
+ tuple.fetch(tuple.elementCount() - 1, (index, begin, end) ->
dataEndOffsetHolder[0] = end);
+
+ ByteBuffer tupleBuffer = tuple.byteBuffer();
+
+ byte flags = tupleBuffer.get(0);
+ int entrySize = BinaryTupleCommon.flagsToEntrySize(flags);
+
+ ByteBuffer prefixBuffer = ByteBuffer.allocate(
+ tupleBuffer.remaining()
+ + (entrySize * (numElements -
tuple.elementCount()))
+ + Integer.BYTES)
+ .order(ORDER)
+ .put(tupleBuffer.slice().limit(dataBeginOffsetHolder[0])); //
header
Review Comment:
replaced
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##########
@@ -73,6 +97,88 @@ public static BinaryTuplePrefix fromBinaryTuple(BinaryTuple
tuple) {
return new BinaryTuplePrefix(tuple.elementCount(), prefixBuffer);
}
+ private static BinaryTuplePrefix expandTuple(int numElements, BinaryTuple
tuple) {
+ assert numElements > tuple.elementCount();
+
+ if (tuple.elementCount() == 0) {
+ return new BinaryTuplePrefix(
+ numElements, new BinaryTuplePrefixBuilder(0, numElements,
0).build()
+ );
+ }
+
+ int[] dataBeginOffsetHolder = new int[1];
+ int[] dataEndOffsetHolder = new int[1];
+
+ tuple.fetch(0, (index, begin, end) -> dataBeginOffsetHolder[0] =
begin);
+ tuple.fetch(tuple.elementCount() - 1, (index, begin, end) ->
dataEndOffsetHolder[0] = end);
+
+ ByteBuffer tupleBuffer = tuple.byteBuffer();
+
+ byte flags = tupleBuffer.get(0);
+ int entrySize = BinaryTupleCommon.flagsToEntrySize(flags);
+
+ ByteBuffer prefixBuffer = ByteBuffer.allocate(
+ tupleBuffer.remaining()
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
