kgusakov commented on code in PR #2698:
URL: https://github.com/apache/ignite-3/pull/2698#discussion_r1371593430
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -482,6 +482,13 @@ public ClusterService clusterService() {
return cluster;
}
+ @Override
+ public void updateConfiguration(PeersAndLearners configuration) {
Review Comment:
Actually I meant that many methods from `RaftGroupServiceImpl` are not
threadsafe, for example refreshMembers called in paralell with
refreshMembers/addLearners/addPeers and other - can produce the client with the
(peers, learners) pairs which is meaningless and weren't exist in any point of
time in fact.
So, it is not connected with only this method, but I created the
https://issues.apache.org/jira/browse/IGNITE-20738 and will mark this method
with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
