lowka commented on code in PR #2752:
URL: https://github.com/apache/ignite-3/pull/2752#discussion_r1372850728
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestBuilders.java:
##########
@@ -515,18 +761,27 @@ public ClusterBuilder end() {
return parent;
}
- private TestTable build() {
- TableDescriptorImpl tableDescriptor = new
TableDescriptorImpl(columns, distribution);
+ private List<CatalogCommand> build() {
+ List<CatalogCommand> commands = new ArrayList<>(1 +
indexBuilders.size());
- List<IgniteIndex> indexes = indexBuilders.stream()
- .map(idx -> idx.build(tableDescriptor))
- .collect(Collectors.toList());
+ commands.add(
+ CreateTableCommand.builder()
+ .schemaName("PUBLIC")
Review Comment:
Perhaps we can expose schema name via builder and assign default value to
`PUBLIC` (Catalog::DEFAULT_SCHEMA_NAME would be better). What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
