vldpyatkov commented on code in PR #2757:
URL: https://github.com/apache/ignite-3/pull/2757#discussion_r1373320502


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -787,6 +790,13 @@ public CompletableFuture<Void> closeAsync() {
         }
 
         private void enlistPartitions(MappedFragment mappedFragment, 
InternalTransaction tx) {
+            // It's possible to have null txState if transaction isn't started 
yet.

Review Comment:
   I changed this code. Currently, I don't shure this ticket is required.



##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -787,6 +790,13 @@ public CompletableFuture<Void> closeAsync() {
         }
 
         private void enlistPartitions(MappedFragment mappedFragment, 
InternalTransaction tx) {
+            // It's possible to have null txState if transaction isn't started 
yet.

Review Comment:
   I changed this code. Currently, I don't think this ticket is required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to