nizhikov commented on code in PR #11014:
URL: https://github.com/apache/ignite/pull/11014#discussion_r1375921048
##########
modules/core/src/main/java/org/apache/ignite/dump/DumpReader.java:
##########
@@ -108,11 +109,22 @@ public DumpReader(DumpReaderConfiguration cfg,
IgniteLogger log) {
AtomicBoolean skip = new AtomicBoolean(false);
+ Map<Integer, Set<Integer>> groups = cfg.skipCopies() ? new
HashMap<>() : null;
+
for (Map.Entry<Integer, List<String>> e :
grpToNodes.entrySet()) {
int grp = e.getKey();
for (String node : e.getValue()) {
for (int part : dump.partitions(node, grp)) {
+ if (groups != null && !groups.computeIfAbsent(grp,
key -> new HashSet<>()).add(part)) {
+ if (log.isDebugEnabled()) {
Review Comment:
Let's log on info level.
##########
modules/core/src/main/java/org/apache/ignite/dump/DumpReaderConfiguration.java:
##########
@@ -58,12 +58,15 @@ public class DumpReaderConfiguration {
/** Cache group names. */
private String[] cacheGroupNames;
+ /** Skip copies. */
+ private boolean skipCopies;
Review Comment:
can be final?
##########
modules/core/src/main/java/org/apache/ignite/dump/DumpReader.java:
##########
@@ -89,13 +90,13 @@ public DumpReader(DumpReaderConfiguration cfg, IgniteLogger
log) {
Map<Integer, List<String>> grpToNodes = new HashMap<>();
- Set<Integer> cacheGroupIds = cfg.cacheGroupNames() != null
+ Set<Integer> cacheGrpIds = cfg.cacheGroupNames() != null
Review Comment:
Seems these changes not related to the ticket. Please, revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
