AMashenkov commented on code in PR #2763:
URL: https://github.com/apache/ignite-3/pull/2763#discussion_r1376053297
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -399,7 +401,14 @@ public void stop() throws Exception {
.map(mgr -> mgr.close(true))
.toArray(CompletableFuture[]::new)
);
- f.join();
+
+ try {
+ f.get(30, TimeUnit.SECONDS);
+ } catch (TimeoutException e) {
+ LOG.warn("Could not stop in 30 seconds, something is wrong", e);
+
+ throw e;
+ }
Review Comment:
I agree that uninterruptible `f.join()` is evil and can lead TC agent
hanging.
`f.get()` is interruptible and should resolve the issue.
However, when graceful stop takes a bit more than timeout, a partially
stopped node may affect the next test, and make the test flaky with no reason.
The investigation of such can become a hard part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
