rpuch commented on code in PR #2758:
URL: https://github.com/apache/ignite-3/pull/2758#discussion_r1376306584
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java:
##########
@@ -97,6 +100,9 @@
* Raft server implementation on top of forked JRaft library.
*/
public class JraftServerImpl implements RaftServer {
+ /** Enables logit log storage. {@code true} by default. */
+ public static final String LOGIT_STORAGE_ENABLED_PROPERTY =
"LOGIT_STORAGE_ENABLED";
Review Comment:
Is using a system property a temporary solution?
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/logit/storage/file/index/IndexFile.java:
##########
@@ -22,7 +22,7 @@
import org.apache.ignite.internal.logger.IgniteLogger;
import org.apache.ignite.internal.logger.Loggers;
-import org.apache.ignite.raft.jraft.storage.logit.storage.file.AbstractFile;
+import org.apache.ignite.raft.jraft.option.RaftOptions;import
org.apache.ignite.raft.jraft.storage.logit.storage.file.AbstractFile;
Review Comment:
Double imports
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/logit/storage/db/SegmentLogDB.java:
##########
@@ -17,15 +17,15 @@
package org.apache.ignite.raft.jraft.storage.logit.storage.db;
-import org.apache.ignite.raft.jraft.storage.logit.storage.file.FileType;
+import java.util.concurrent.ScheduledExecutorService;import
org.apache.ignite.raft.jraft.storage.logit.storage.file.FileType;
Review Comment:
Imports are on the same line
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/logit/option/StoreOptions.java:
##########
@@ -27,13 +27,13 @@ public class StoreOptions {
private static final String storagePath = "localLog";
- // Default is 0.5G
- private int segmentFileSize = 1024 * 1024 *
512;
+ // Default is 64Mb.
Review Comment:
There is probably a reason for the default to differ from the original
default. Could it be put in this comment?
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/logit/storage/file/segment/SegmentFile.java:
##########
@@ -102,9 +102,9 @@ public byte[] lookupData(final long logIndex, final int
pos) {
getFilePath(), logIndex, pos,
this.header.getFirstLogIndex(), getLastLogIndex());
return null;
}
- if (pos > getFlushedPosition()) {
+ if (pos > getWrotePosition()) {
Review Comment:
I don't understand this change, could you please elaborate?
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/logit/storage/file/segment/SegmentFile.java:
##########
@@ -24,7 +24,7 @@
import org.apache.ignite.internal.logger.Loggers;
import org.apache.ignite.raft.jraft.entity.LogEntry;
import org.apache.ignite.raft.jraft.entity.codec.v1.LogEntryV1CodecFactory;
-import org.apache.ignite.raft.jraft.storage.logit.storage.file.AbstractFile;
+import org.apache.ignite.raft.jraft.option.RaftOptions;import
org.apache.ignite.raft.jraft.storage.logit.storage.file.AbstractFile;
Review Comment:
Double imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
