sanpwc commented on code in PR #2751:
URL: https://github.com/apache/ignite-3/pull/2751#discussion_r1382922756
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/TxManager.java:
##########
@@ -116,22 +115,27 @@ public interface TxManager extends IgniteComponent {
* transaction execution. The tracker is also used to determine
the read timestamp for read-only transactions. Each client
* should pass its own tracker to provide linearizability between
read-write and read-only transactions started by this client.
* @param commitPartition Partition to store a transaction state.
- * @param recipientNode Recipient node.
- * @param term Raft term.
- * @param commit {@code True} if a commit requested.
+ * @param commit {@code true} if a commit requested.
* @param enlistedGroups Enlisted partition groups with consistency token.
* @param txId Transaction id.
*/
CompletableFuture<Void> finish(
HybridTimestampTracker timestampTracker,
TablePartitionId commitPartition,
- ClusterNode recipientNode,
- Long term,
boolean commit,
Map<TablePartitionId, Long> enlistedGroups,
UUID txId
);
+
+ /**
+ * Make sure the state of the provided transaction is updated correctly.
+ *
+ * @param commit {@code true} if a commit requested.
+ * @param txId Transaction id.
+ */
+ CompletableFuture<Void> finishEmpty(boolean commit, UUID txId);
Review Comment:
Agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
