lowka commented on code in PR #2800:
URL: https://github.com/apache/ignite-3/pull/2800#discussion_r1386411014
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/SqlRowHandler.java:
##########
@@ -440,4 +424,56 @@ RowSchema rowSchema() {
}
}
}
+
+ private static class RowBuilderImpl implements RowBuilder<RowWrapper> {
+
+ private final int schemaLen;
+
+ private final RowSchema rowSchema;
+
+ Object[] data;
+
+ int fieldIdx;
+
+ RowBuilderImpl(RowSchema rowSchema) {
+ this.rowSchema = rowSchema;
+ this.schemaLen = rowSchema.fields().size();
+ fieldIdx = 0;
+ }
+
+ /** {@inheritDoc} */
+ @Override
+ public RowBuilder<RowWrapper> newRow() {
Review Comment:
Fixed. Replaced `newRow` with a `reset `method.
Rewrote the code with calls to `buildAndReset`, which should be less error
prone than both `newRow` + `build` and `build` + `reset`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
