sk0x50 commented on code in PR #2821:
URL: https://github.com/apache/ignite-3/pull/2821#discussion_r1387813650
##########
modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridTimestamp.java:
##########
@@ -230,7 +233,9 @@ public int compareTo(HybridTimestamp other) {
@Override
public String toString() {
- return S.toString(HybridTimestamp.class, this, "physical",
getPhysical(), "logical", getLogical());
+ String formattedTime =
DATE_FORMATTER.format(Instant.ofEpochMilli(getPhysical()).atZone(ZoneId.systemDefault()));
+
+ return String.format("HybridTimestamp [physical=%s, logical=%d,
composite=%d]", formattedTime, getLogical(), time);
Review Comment:
In general, the proposed approach looks good to me. Perhaps, `composite` is
not so descriptive as `timestamp`, but again, it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
