sanpwc commented on code in PR #2822:
URL: https://github.com/apache/ignite-3/pull/2822#discussion_r1390705558
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -575,8 +575,12 @@ private void handleThrowable(
) {
if (recoverable(err)) {
LOG.warn(
- "Recoverable error during the request type={} occurred
(will be retried on the randomly selected node): ",
- err, sentRequest.getClass().getSimpleName()
+ "Recoverable error during the request occurred (will be
retried on the randomly selected node) "
+ + "[type={}, groupId={}, peer={}].",
+ err,
+ sentRequest.getClass().getSimpleName(),
Review Comment:
Agree. And because request contains not only a command but alsoa groupId it
won't be necessary to log latter explicitly.
```
@IgniteToStringInclude
private final WriteCommand command;
@IgniteToStringInclude
private final String groupId;
```
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -575,8 +575,12 @@ private void handleThrowable(
) {
if (recoverable(err)) {
LOG.warn(
- "Recoverable error during the request type={} occurred
(will be retried on the randomly selected node): ",
- err, sentRequest.getClass().getSimpleName()
+ "Recoverable error during the request occurred (will be
retried on the randomly selected node) "
+ + "[type={}, groupId={}, peer={}].",
+ err,
+ sentRequest.getClass().getSimpleName(),
Review Comment:
Agree. And because request contains not only a command but also groupId it
won't be necessary to log latter explicitly.
```
@IgniteToStringInclude
private final WriteCommand command;
@IgniteToStringInclude
private final String groupId;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
