nizhikov commented on code in PR #11040:
URL: https://github.com/apache/ignite/pull/11040#discussion_r1393988064
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/dump/CreateDumpFutureTask.java:
##########
@@ -444,12 +452,14 @@ public PartitionDumpContext(CacheGroupContext gctx, int
part, ConcurrentMap<Long
for (int cache : gctx.cacheIds())
changed.put(cache, new GridConcurrentHashSet<>());
- File dumpFile = new File(groupDirectory(gctx),
PART_FILE_PREFIX + part + DUMP_FILE_EXT);
+ String fileName = PART_FILE_PREFIX + part + DUMP_FILE_EXT;
+
+ File dumpFile = new File(groupDirectory(gctx), zip ? fileName
+ ZIP_SUFFIX : fileName);
if (!dumpFile.createNewFile())
throw new IgniteException("Dump file can't be created: " +
dumpFile);
- file = ioFactory.create(dumpFile);
+ file = zip ? new ZipFileIO(dumpFile) :
ioFactory.create(dumpFile);
Review Comment:
It seems we must use another `ioFactory` when `compress==true`.
We can add `.zip` extension in it, also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
