sanpwc commented on code in PR #2825:
URL: https://github.com/apache/ignite-3/pull/2825#discussion_r1395812387
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java:
##########
@@ -204,6 +212,7 @@ public void start() {
@Override
public void stop() throws Exception {
metricManager.unregisterSource(metrics);
Review Comment:
> There is no such action. stop and start
I'm talking about concurrent stop and e.g.
notification(PrimaryReplicaElection) processing. It might be covered with
separate ticket in order not to mess given one.
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java:
##########
@@ -204,6 +212,7 @@ public void start() {
@Override
public void stop() throws Exception {
metricManager.unregisterSource(metrics);
Review Comment:
> There is no such action. stop and start
I'm talking about concurrent stop and e.g.
notification(PrimaryReplicaElection) processing. It might be covered with
separate ticket in order not to mess given one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
