valepakh commented on code in PR #2843:
URL: https://github.com/apache/ignite-3/pull/2843#discussion_r1398814379
##########
modules/compute/src/main/java/org/apache/ignite/internal/compute/ComputeComponentImpl.java:
##########
@@ -268,46 +224,25 @@ private Object sendExecuteResponse(@Nullable Object
result, @Nullable Throwable
return null;
}
- private <R, J extends ComputeJob<R>> Class<J> jobClass(ClassLoader
jobClassLoader, String jobClassName) {
- try {
- return (Class<J>) Class.forName(jobClassName, true,
jobClassLoader);
- } catch (ClassNotFoundException e) {
- throw new IgniteInternalException("Cannot load job class by name
'" + jobClassName + "'", e);
- }
- }
-
- private CompletableFuture<JobContext> jobClassLoader(List<DeploymentUnit>
units) {
- return jobContextManager.acquireClassLoader(units);
- }
Review Comment:
> What's the point to have non-static one line method with direct method
call?
Brevity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
