vldpyatkov commented on code in PR #2832:
URL: https://github.com/apache/ignite-3/pull/2832#discussion_r1398885722
##########
modules/table/src/testFixtures/java/org/apache/ignite/internal/table/impl/DummyInternalTableImpl.java:
##########
@@ -433,14 +437,26 @@ public TxManager txManager() {
* @param replicaSvc Replica service to use.
*/
public static TxManagerImpl txManager(ReplicaService replicaSvc) {
- return new TxManagerImpl(
+ TopologyService topologyService = mock(TopologyService.class);
+ when(topologyService.localMember()).thenReturn(LOCAL_NODE);
+
+ ClusterService clusterService = mock(ClusterService.class);
+
when(clusterService.messagingService()).thenReturn(mock(MessagingService.class));
+ when(clusterService.topologyService()).thenReturn(topologyService);
+
+ var txManager = new TxManagerImpl(
+ clusterService,
replicaSvc,
new HeapLockManager(),
CLOCK,
new TransactionIdGenerator(0xdeadbeef),
- LOCAL_NODE::id,
- TEST_PLACEMENT_DRIVER
+ TEST_PLACEMENT_DRIVER,
+ () -> DEFAULT_IDLE_SAFE_TIME_PROPAGATION_PERIOD_MILLISECONDS
);
+
+ txManager.start();
Review Comment:
You are right, but it is just a test. Lackly, nothing was violated when the
manager started without stopping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
