lowka commented on code in PR #2848:
URL: https://github.com/apache/ignite-3/pull/2848#discussion_r1399252374
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##########
@@ -872,21 +871,21 @@ private static Row createKeyRow(int id) {
* @return Transaction.
*/
private InternalTransaction startTxWithEnlistedPartition(int partId,
boolean readOnly) {
- Ignite ignite = CLUSTER.aliveNode();
+ IgniteImpl ignite = CLUSTER.aliveNode();
InternalTransaction tx = (InternalTransaction)
ignite.transactions().begin(new TransactionOptions().readOnly(readOnly));
InternalTable table = ((TableViewInternal)
ignite.tables().table(TABLE_NAME)).internalTable();
TablePartitionId tblPartId = new TablePartitionId(table.tableId(),
partId);
- PlacementDriver placementDriver = ((IgniteImpl)
ignite).placementDriver();
+ PlacementDriver placementDriver = (ignite).placementDriver();
ReplicaMeta primaryReplica = IgniteTestUtils.await(
- placementDriver.awaitPrimaryReplica(tblPartId, ((IgniteImpl)
ignite).clock().now(), 30, TimeUnit.SECONDS));
+ placementDriver.awaitPrimaryReplica(tblPartId,
(ignite).clock().now(), 30, TimeUnit.SECONDS));
Review Comment:
> (ignite)
I think these parentheses are redundant.
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##########
@@ -872,21 +871,21 @@ private static Row createKeyRow(int id) {
* @return Transaction.
*/
private InternalTransaction startTxWithEnlistedPartition(int partId,
boolean readOnly) {
- Ignite ignite = CLUSTER.aliveNode();
+ IgniteImpl ignite = CLUSTER.aliveNode();
InternalTransaction tx = (InternalTransaction)
ignite.transactions().begin(new TransactionOptions().readOnly(readOnly));
InternalTable table = ((TableViewInternal)
ignite.tables().table(TABLE_NAME)).internalTable();
TablePartitionId tblPartId = new TablePartitionId(table.tableId(),
partId);
- PlacementDriver placementDriver = ((IgniteImpl)
ignite).placementDriver();
+ PlacementDriver placementDriver = (ignite).placementDriver();
ReplicaMeta primaryReplica = IgniteTestUtils.await(
- placementDriver.awaitPrimaryReplica(tblPartId, ((IgniteImpl)
ignite).clock().now(), 30, TimeUnit.SECONDS));
+ placementDriver.awaitPrimaryReplica(tblPartId,
(ignite).clock().now(), 30, TimeUnit.SECONDS));
Review Comment:
> (ignite)
I think these parentheses are redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]