ptupitsyn commented on code in PR #2825:
URL: https://github.com/apache/ignite-3/pull/2825#discussion_r1402402441


##########
modules/client/src/test/java/org/apache/ignite/client/fakes/FakeInternalTable.java:
##########
@@ -53,6 +53,8 @@
  * Fake internal table.
  */
 public class FakeInternalTable implements InternalTable {
+    public static final int PARTITIONS = 4;

Review Comment:
   Yes, this is used to initialize `FakeCatalogService` and in some other 
places which should have the same number of partitions to make the tests work. 
The idea is to express this dependency explicitly and avoid magic numbers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to