rpuch commented on code in PR #2850: URL: https://github.com/apache/ignite-3/pull/2850#discussion_r1403251886
########## modules/network/src/main/java/org/apache/ignite/internal/network/recovery/message/HandshakeRejectionReason.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network.recovery.message; + +/** + * Reason for handshake rejection. + */ +public enum HandshakeRejectionReason { + /** The sender is stopping. */ + STOPPING, + /** + * The sender has detected that the counterpart launch ID is stale (was earlier used to establish a connection). + * After this is received it makes no sense to retry connections with same node identity (launch ID must be changed + * to make a retry). + */ + STALE_LAUNCH_ID, + /** The sender has detected a clinch and decided to terminate this handshake in favor of the competitor. */ + CLINCH; + + /** + * Returns {@code true} iff the rejection is not expected and should be treated as a critical failure (requiring + * the rejected node to restart). + */ + public boolean critical() { Review Comment: Renamed it to `restartRequired()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
