nizhikov commented on code in PR #246:
URL: https://github.com/apache/ignite-extensions/pull/246#discussion_r1404044978
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/AbstractKafkaToIgniteCdcStreamer.java:
##########
@@ -107,9 +107,14 @@ public AbstractKafkaToIgniteCdcStreamer(Properties
kafkaProps, KafkaToIgniteCdcS
appliers = new ArrayList<>(streamerCfg.getThreadCount());
runners = new ArrayList<>(streamerCfg.getThreadCount());
- if (!kafkaProps.containsKey(ConsumerConfig.GROUP_ID_CONFIG))
+ String grp = kafkaProps.getProperty(ConsumerConfig.GROUP_ID_CONFIG);
+
+ if (grp == null)
Review Comment:
Can we make this check with `A.ensure` like other parameters?
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/AbstractKafkaToIgniteCdcStreamer.java:
##########
@@ -107,9 +107,14 @@ public AbstractKafkaToIgniteCdcStreamer(Properties
kafkaProps, KafkaToIgniteCdcS
appliers = new ArrayList<>(streamerCfg.getThreadCount());
runners = new ArrayList<>(streamerCfg.getThreadCount());
- if (!kafkaProps.containsKey(ConsumerConfig.GROUP_ID_CONFIG))
+ String grp = kafkaProps.getProperty(ConsumerConfig.GROUP_ID_CONFIG);
+
+ if (grp == null)
throw new IllegalArgumentException("Kafka properties don't
contains " + ConsumerConfig.GROUP_ID_CONFIG);
+ if (grp.equals(streamerCfg.getMetadataConsumerGroup()))
Review Comment:
Can we make this check with `A.ensure` like other parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
