xtern commented on code in PR #2846:
URL: https://github.com/apache/ignite-3/pull/2846#discussion_r1406359737
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/QueryTransactionWrapperSelfTest.java:
##########
@@ -91,27 +97,51 @@ public void testCommitImplicit() {
@Test
public void testRollbackImplicit() {
- QueryTransactionWrapper wrapper = prepareImplicitTx();
- NoOpTransaction tx = (NoOpTransaction) wrapper.unwrap();
+ NoOpTransaction tx = new NoOpTransaction("test");
+ QueryTransactionWrapper wrapper = new QueryTransactionWrapper(tx,
true);
wrapper.rollback();
assertThat(tx.rollbackFuture().isDone(), equalTo(true));
assertThat(tx.commitFuture().isDone(), equalTo(false));
}
- private QueryTransactionWrapper prepareImplicitTx() {
- when(transactions.begin(any())).thenReturn(new
NoOpTransaction("test"));
+ @Test
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
