xtern commented on code in PR #2884:
URL: https://github.com/apache/ignite-3/pull/2884#discussion_r1408015713
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlApiBaseTest.java:
##########
@@ -826,6 +826,48 @@ public void
resultSetCloseShouldFinishImplicitTransaction() {
assertEquals(0, txManager().pending(), "Expected no pending
transactions");
}
+
+ @Test
+ public void runScriptThatCompletesSuccessfully() {
+ IgniteSql sql = igniteSql();
+
+ try (Session session = sql.createSession()) {
+ executeScript(session,
+ "CREATE TABLE test (id INT PRIMARY KEY, step INTEGER); "
+ + "INSERT INTO test VALUES(1, 0); "
Review Comment:
Let's add START TRANSACTION before INSERT and COMMIT after last UPDATE.
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlApiBaseTest.java:
##########
@@ -826,6 +826,48 @@ public void
resultSetCloseShouldFinishImplicitTransaction() {
assertEquals(0, txManager().pending(), "Expected no pending
transactions");
}
+
+ @Test
+ public void runScriptThatCompletesSuccessfully() {
+ IgniteSql sql = igniteSql();
+
+ try (Session session = sql.createSession()) {
+ executeScript(session,
+ "CREATE TABLE test (id INT PRIMARY KEY, step INTEGER); "
+ + "INSERT INTO test VALUES(1, 0); "
Review Comment:
Let's add `START TRANSACTION` before INSERT and `COMMIT` after last UPDATE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
