Cyrill commented on code in PR #2877:
URL: https://github.com/apache/ignite-3/pull/2877#discussion_r1408071254
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/TxManager.java:
##########
@@ -146,6 +147,22 @@ CompletableFuture<Void> cleanup(
@Nullable HybridTimestamp commitTimestamp
);
+ /**
+ * Sends unlock request to the primary nodes of each one of {@code
partitions}.
+ *
+ * @param partitions Enlisted partition groups.
+ * @param commit {@code true} if a commit requested.
+ * @param commitTimestamp Commit timestamp ({@code null} if it's an abort).
+ * @param txId Transaction id.
+ * @return Completable future of Void.
+ */
+ CompletableFuture<Void> unlock(
+ Collection<TablePartitionId> partitions,
Review Comment:
Unlock in this form is called from the commit partition primary, so the
partitions is always present.
The recovery case will be added in a separate task IGNITE-20735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
