xtern commented on code in PR #2846: URL: https://github.com/apache/ignite-3/pull/2846#discussion_r1409552419
########## modules/api/src/main/java/org/apache/ignite/sql/ExternalTransactionNotSupportedException.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.sql; + +import java.util.UUID; +import org.apache.ignite.lang.ErrorGroups.Sql; + +/** + * The exception is thrown when an attempt is made to execute a transaction control statement + * ({@code START TRANSACTION} or {@code COMMIT}) while an external transaction is already running. + */ +public class ExternalTransactionNotSupportedException extends SqlException { + /** + * Default constructor. + */ + public ExternalTransactionNotSupportedException() { + super(Sql.TX_CONTROL_INSIDE_EXTERNAL_TX_ERR, "Transaction control statement cannot be executed within an external transaction."); + } + + /** + * Constructor is required to copy this exception. + */ + @Deprecated Review Comment: As stated in the description, this constructor is required to copy this exception.(see `ExceptinoUtils,copyExceptionWithCause`). We also have a test `IgniteExceptionArchTest` that verifies that all exceptions inherited from IgniteException must have such a constructor (I need to add this constructor or add this exception-class to "exclusions" in this test) Are you suggesting to exclude it from this test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
