AMashenkov commented on code in PR #2846:
URL: https://github.com/apache/ignite-3/pull/2846#discussion_r1413689841
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/AsyncSqlCursorImpl.java:
##########
@@ -156,8 +157,10 @@ public CompletableFuture<Void> closeAsync() {
dataCursor.closeAsync()
.thenCompose(ignored -> txWrapper.commitImplicit())
- .thenRun(onClose)
.whenComplete((r, e) -> {
+ // Anyway run close handler.
+ onClose.run();
Review Comment:
Should we catch and/or log an exception from `onClose()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
