Cyrill commented on code in PR #2877:
URL: https://github.com/apache/ignite-3/pull/2877#discussion_r1415264332
##########
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItTxDistributedCleanupRecoveryTest.java:
##########
@@ -155,47 +66,19 @@ public CompletableFuture<ReplicaResult>
invoke(ReplicaRequest request, String se
accounts = txTestCluster.startTable(ACC_TABLE_NAME, ACC_TABLE_ID,
ACCOUNTS_SCHEMA);
customers = txTestCluster.startTable(CUST_TABLE_NAME, CUST_TABLE_ID,
CUSTOMERS_SCHEMA);
- log.info("Tables have been started");
- }
-
-
- @Test
- @Override
- public void testDeleteUpsertCommit() throws TransactionException {
- // The value of 6 is higher than the default retry count.
- // So we should give up retrying and crash.
- setDefaultRetryCount(6);
-
- assertThrows(TransactionException.class, () ->
deleteUpsert().commit());
- }
-
- @Test
Review Comment:
They're no longer relevant. These three overridden test methods were
actually checking that the request fails if we exceed the allowed cleanup retry
count (which is 5).
But considering that cleanups are local now and we anyway are going to get
rid of the retry count, these tests became useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
