sanpwc commented on code in PR #2873:
URL: https://github.com/apache/ignite-3/pull/2873#discussion_r1417282380
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##########
@@ -479,6 +479,11 @@ private CompletableFuture<Integer>
saveUpdate(UpdateProducer updateProducer, int
int newVersion = catalog.version() + 1;
+ // It is quite important to preserve such behavior: we wait here for
versionTracker to be updated. It is updated when all events
+ // that were triggered by this changed will be completed. That means
that any Catalog update will be completed only
Review Comment:
typo changed -> change
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1070,7 +1070,7 @@ private CompletableFuture<?> createTableLocally(
if (partitionAssignments(vaultManager, tableId, 0) != null) {
assignmentsFuture =
completedFuture(tableAssignments(vaultManager, tableId,
zoneDescriptor.partitions()));
} else {
- assignmentsFuture =
distributionZoneManager.dataNodes(causalityToken, zoneId)
+ assignmentsFuture =
distributionZoneManager.dataNodes(causalityToken, catalogVersion, zoneId)
Review Comment:
It might be a bit fragile. Let's assume that tableManager.start() is
partially asynchronous. In that case we may start new events processing while
recovery on restart isn't fully finished. Generally speaking it'll be a
disaster. But within given context we may finish with non-matching token and
catalogVersion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
