ibessonov commented on code in PR #2936:
URL: https://github.com/apache/ignite-3/pull/2936#discussion_r1420352667
##########
modules/core/src/main/java/org/apache/ignite/internal/util/CompletableFutures.java:
##########
@@ -82,4 +83,27 @@ public static <T> CompletableFuture<Set<T>>
emptySetCompletedFuture() {
public static <K, V> CompletableFuture<Map<K, V>>
emptyMapCompletedFuture() {
return (CompletableFuture<Map<K, V>>) (CompletableFuture<?>)
EMPTY_MAP_COMPLETED_FUTURE;
}
+
+ /**
+ * Returns a future that is completed when all provided futures complete
(the behavior is identical to {@link CompletableFuture#allOf}).
+ *
+ * <p>If the future completes successfully, it aggregates the results of
the source futures into a {@code List}.
+ *
+ * @param cfs Source futures.
+ * @param <T> Type of the result of the source futures.
+ * @return Future that completes with a list of results from the source
futures.
+ */
+ @SafeVarargs
+ public static <T> CompletableFuture<List<T>> allOf(CompletableFuture<T>...
cfs) {
Review Comment:
Maybe it's not a problem, I expressed my opinion. For me personally that's
an issue, because now I'd have to disassociate `allOf` with one specific thing,
and start associating it with two sligthly different things. I'm fine if you
leave the old name, it's not a blocker comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
