ascherbakoff commented on code in PR #2720:
URL: https://github.com/apache/ignite-3/pull/2720#discussion_r1421722987


##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/LockManager.java:
##########
@@ -36,14 +36,15 @@ public interface LockManager extends 
EventProducer<LockEvent, LockEventParameter
      * @param lockMode Lock mode, for example shared, exclusive, 
intention-shared etc.
      * @return The future with gained lock that will be completed when a lock 
is successfully acquired.
      */
-    public CompletableFuture<Lock> acquire(UUID txId, LockKey lockKey, 
LockMode lockMode);
+    CompletableFuture<Lock> acquire(UUID txId, LockKey lockKey, LockMode 
lockMode);
 
     /**
      * Attempts to release the specified lock.
      *
      * @param lock Lock to release.
      */
-    public void release(Lock lock);
+    @TestOnly

Review Comment:
   I don't know. It is called internally from production method, so looks OK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to