denis-chudov commented on code in PR #2918:
URL: https://github.com/apache/ignite-3/pull/2918#discussion_r1422743971
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -409,15 +411,16 @@ private CompletableFuture<?> durableCleanup(UUID txId,
TxMeta txMeta) {
.thenCompose(f -> f);
}
- private void markLocksReleased(
- UUID txId,
- Collection<TablePartitionId> enlistedPartitions,
- TxState txState,
- @Nullable HybridTimestamp commitTimestamp
- ) {
- TxMeta newTxMeta = new TxMeta(txState, enlistedPartitions,
commitTimestamp, true);
+ private void markLocksReleased(UUID txId) {
+ reliableCatalogVersionFor(hybridClock.now()).thenAccept(catalogVersion
-> {
Review Comment:
I think it's not the thing that should be fixed in the current PR. We dont
have another proper timestamp here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
