Flaugh24 commented on code in PR #2941:
URL: https://github.com/apache/ignite-3/pull/2941#discussion_r1423881008
##########
modules/rest/src/main/java/org/apache/ignite/internal/rest/RestComponent.java:
##########
@@ -83,9 +87,14 @@ public class RestComponent implements IgniteComponent {
/**
* Creates a new instance of REST module.
*/
- public RestComponent(List<Supplier<RestFactory>> restFactories,
RestConfiguration restConfiguration) {
+ public RestComponent(
+ List<Supplier<RestFactory>> restFactories,
+ RestManagerProvider restManagerProvider,
Review Comment:
Why do you need here RestManagerProvider? Not just RestManager
##########
modules/rest/src/main/java/org/apache/ignite/internal/rest/ClusterInitializationHttpFilter.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.rest;
+
+import io.micronaut.core.async.publisher.Publishers;
+import io.micronaut.http.HttpRequest;
+import io.micronaut.http.MutableHttpResponse;
+import io.micronaut.http.annotation.Filter;
+import io.micronaut.http.filter.HttpServerFilter;
+import io.micronaut.http.filter.ServerFilterChain;
+import org.apache.ignite.internal.rest.api.Problem;
+import org.apache.ignite.internal.rest.constants.HttpCode;
+import org.apache.ignite.internal.rest.problem.HttpProblemResponse;
+import org.reactivestreams.Publisher;
+
+/**
+ * Filters out endpoints that are not allowed to be accessed during cluster
initialization.
+ */
+@Filter(Filter.MATCH_ALL_PATTERN)
+public class ClusterInitializationHttpFilter implements HttpServerFilter {
Review Comment:
Should we add a new filter? We could integrate the logic into
NodeOnlyEndpointsFilter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
