IgGusev commented on code in PR #11097:
URL: https://github.com/apache/ignite/pull/11097#discussion_r1426664676
##########
docs/_docs/code-snippets/k8s/stateless/deployment.yaml:
##########
@@ -0,0 +1,85 @@
+# An example of a Kubernetes configuration for pod deployment.
Review Comment:
We should use already existing template file instead of creating random new
one.
##########
docs/_docs/code-snippets/k8s/stateful/statefulset.yaml:
##########
@@ -0,0 +1,108 @@
+# An example of a Kubernetes configuration for pod deployment.
Review Comment:
This file is not used, why is it added?
##########
.vscode/settings.json:
##########
@@ -0,0 +1 @@
+{}
Review Comment:
What is this file here for?
##########
docs/_docs/installation/kubernetes/generic-configuration.adoc:
##########
@@ -21,6 +21,10 @@ published: false
:soft_name: Kubernetes
:serviceName:
+//:configDir: /code-snippets/k8s
+//:script: /code-snippets/k8s/setup.sh
+//:javaFile: /{javaCodeDir}/k8s/K8s.java
Review Comment:
Why is this added?
##########
docs/_docs/installation/kubernetes/generic-configuration.adoc:
##########
@@ -159,34 +163,35 @@ include::{script}[tags=create-configmap]
=== Creating Pod Configuration
-Now we will create a configuration for pods.
-In the case of stateless deployment, we will use a
link:https://kubernetes.io/docs/concepts/workloads/controllers/deployment/[Deployment,window=_blank].
-For a stateful deployment, we will use a
link:https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/[StatefulSet,window=_blank].
+Now we create a configuration for pods that use a
link:https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/[StatefulSet,window=_blank].
[tabs]
--
tab:Configuration without persistence[]
-Our Deployment configuration will deploy a ReplicaSet with two pods running
Ignite {version}.
+Our non-persistent configuration deploys a ReplicaSet with two pods running
GridGain Community Edition v. {version}.
+If you want to use Enterprise or Ultimate Edition, change the
`spec.template.spec.containers.image` property in the configuration file.
-In the container's configuration, we will:
-* Enable the “ignite-kubernetes” and “ignite-rest-http”
link:installation/installing-using-docker#enabling-modules[modules].
+In the container's configuration, we:
+
+* Enable the “ignite-kubernetes” and “ignite-rest-http”
link:installation-guide/installing-using-docker#enabling-modules[modules].
* Use the configuration file from the ConfigMap we created earlier.
* Open a number of ports:
** 47100 — the communication port
** 47500 — the discovery port
** 49112 — the default JMX port
** 10800 — thin client/JDBC/ODBC port
** 8080 — REST API port
+* Create a volume for storing metadata.
-The deployment configuration file might look like as follows:
+The configuration file might look like as follows:
.deployment.yaml
[source, yaml,subs="attributes,specialchars"]
----
-include::{configDir}/stateless/deployment-template.yaml[tag=config-block]
+include::{configDir}/stateless/deployment.yaml[]
Review Comment:
There already exists a template file - we should use it instead of adding
new files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
