denis-chudov commented on code in PR #2856:
URL: https://github.com/apache/ignite-3/pull/2856#discussion_r1426965688
##########
modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -354,6 +354,9 @@ public static class Transactions {
/** Coordinator tries to commit a transaction that has already been
aborted. */
public static final int TX_WAS_ABORTED_ERR =
TX_ERR_GROUP.registerErrorCode((short) 15);
+
+ /** Coordinator tries to abort a transaction that has already been
committed. */
+ public static final int TX_WAS_COMMITTED_ERR =
TX_ERR_GROUP.registerErrorCode((short) 16);
Review Comment:
You should also check this code in `TxManagerImpl#durableFinish` to stop
durable finish. By the way, seems we dont return the correct error code from
`PartitionListener#onTxStateStorageCasFail` - there is
`TX_UNEXPECTED_STATE_ERR` in any case, should be either `TX_WAS_ABORTED_ERR` or
`TX_WAS_COMMITTED_ERR`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
