sanpwc commented on code in PR #2958:
URL: https://github.com/apache/ignite-3/pull/2958#discussion_r1427908892
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/command/SafeTimePropagatingCommand.java:
##########
@@ -46,4 +46,11 @@ default void safeTimeLong(long safeTime) {
default HybridTimestamp safeTime() {
return hybridTimestamp(safeTimeLong());
}
+
+ /**
+ * Public clone version that is implemented in generated *Impl class.
+ */
+ default Object clone() throws CloneNotSupportedException {
Review Comment:
If Object clone() in NetworkMessage (or NetworkMessage clone() which
currently doesn't matter) doesn't through an exception implementation (*Impl)
also should not declare throws CloneNotSupportedException. And because every
MessageImple class directly extends Object supler.clone() will through
CloneNotSupportedException and thus should be handled. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
