nizhikov commented on code in PR #11112:
URL: https://github.com/apache/ignite/pull/11112#discussion_r1432661287
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/dump/CreateDumpFutureTask.java:
##########
@@ -614,6 +654,38 @@ private boolean isAfterStart(GridCacheVersion ver) {
return (startVer != null && ver.isGreater(startVer)) &&
!isolatedStreamerVer.equals(ver);
}
+ /**
+ * Iterator returned by {@link
IgniteCacheOffheapManager#reservedIterator(int, AffinityTopologyVersion)}
+ * iterates key in ascending order set by {@link
CacheDataTree#compare(BPlusIO, long, int, CacheSearchRow)}.
+ * So if key changed by the user (see {@link #writeChanged(int, long,
KeyCacheObject, CacheObject, GridCacheVersion)})
+ * is greater then last key written by partition iterator then it not
saved in dump, already, and must be written.
Review Comment:
Fixed both
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/dump/IgniteConcurrentCacheDumpTest.java:
##########
@@ -43,7 +43,7 @@ public static List<Object[]> params() {
for (boolean encrypted : new boolean[]{true, false})
for (int nodes : new int[]{2, 3})
for (int backups : new int[]{1, 2})
- for (boolean persistence : new boolean[]{true, false})
+ for (boolean persistence : new boolean[]{/*true,*/ false})
Review Comment:
Reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
