agura commented on code in PR #2882: URL: https://github.com/apache/ignite-3/pull/2882#discussion_r1434021717
########## modules/api/src/main/java/org/apache/ignite/table/criteria/CriteriaQuerySource.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.table.criteria; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.lang.AsyncCursor; +import org.apache.ignite.lang.Cursor; +import org.apache.ignite.sql.SqlException; +import org.apache.ignite.tx.Transaction; +import org.jetbrains.annotations.Nullable; + +/** + * Represents a criteria query facade that can be used to executes a query to a view using a predicate. Review Comment: > to executes a query to a view What kind of view do you mean? I believe it is record view. Please, use right terms. ########## modules/api/src/main/java/org/apache/ignite/table/criteria/CriteriaQuerySource.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.table.criteria; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.lang.AsyncCursor; +import org.apache.ignite.lang.Cursor; +import org.apache.ignite.sql.SqlException; +import org.apache.ignite.tx.Transaction; +import org.jetbrains.annotations.Nullable; + +/** + * Represents a criteria query facade that can be used to executes a query to a view using a predicate. + * + * @param <T> The type of elements returned by iterator. + */ +public interface CriteriaQuerySource<T> { + /** + * Executes a query to a view using a predicate. + * + * @param tx Transaction to execute the query within or {@code null} to run within implicit transaction. + * @param criteria The predicate to filter entries or {@code null} to return all entries in view. + * @return Iterator with query results. + * @throws SqlException If failed. + */ + default Cursor<T> queryCriteria(@Nullable Transaction tx, @Nullable Criteria criteria) { Review Comment: I don't like the naming. You don't query criteria, instead you execute query which is based on criteria. In addition I see a lot of noise with criteria, e.g. query**Criteria**(null, **criteria**, **criteria**Opts). ########## modules/api/src/main/java/org/apache/ignite/table/criteria/CriteriaQuerySource.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.table.criteria; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.lang.AsyncCursor; +import org.apache.ignite.lang.Cursor; +import org.apache.ignite.sql.SqlException; +import org.apache.ignite.tx.Transaction; +import org.jetbrains.annotations.Nullable; + +/** + * Represents a criteria query facade that can be used to executes a query to a view using a predicate. + * + * @param <T> The type of elements returned by iterator. + */ +public interface CriteriaQuerySource<T> { + /** + * Executes a query to a view using a predicate. + * + * @param tx Transaction to execute the query within or {@code null} to run within implicit transaction. + * @param criteria The predicate to filter entries or {@code null} to return all entries in view. Review Comment: > to return all entries in view. What kind of view do you mean? I believe it is record view. Please, use right terms. The view is a standard term for SQL. In order to have right semantic please use record view term here and everywhere. ########## modules/core/src/main/java/org/apache/ignite/internal/table/criteria/SyncCursorAdapter.java: ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.table.criteria; + +import static org.apache.ignite.internal.lang.IgniteExceptionMapperUtil.convertToPublicFuture; +import static org.apache.ignite.internal.lang.IgniteExceptionMapperUtil.mapToPublicException; +import static org.apache.ignite.internal.util.ExceptionUtils.sneakyThrow; +import static org.apache.ignite.internal.util.ExceptionUtils.unwrapCause; + +import java.util.Iterator; +import java.util.concurrent.CompletionException; +import java.util.concurrent.CompletionStage; +import org.apache.ignite.lang.AsyncCursor; +import org.apache.ignite.lang.Cursor; + +/** + * Synchronous wrapper over {@link AsyncCursor}. + */ +public class SyncCursorAdapter<T> implements Cursor<T> { Review Comment: If it is not Async it is obviously Sync. Just redundant Sync word. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
