zstan commented on code in PR #2964:
URL: https://github.com/apache/ignite-3/pull/2964#discussion_r1434783173
##########
modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -105,7 +106,7 @@ public static ErrorGroup errorGroupByGroupCode(short
groupCode) {
* @param code Full error code
* @return Error Group.
*/
- public static ErrorGroup errorGroupByCode(int code) {
+ public static @Nullable ErrorGroup errorGroupByCode(int code) {
Review Comment:
done
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/registry/UpgradingRowAdapter.java:
##########
@@ -160,7 +163,7 @@ public Byte byteValueBoxed(int colIdx) throws
InvalidTypeException {
Column column = mappedId < 0 ? mapper.mappedColumn(colIdx) :
super.schema().column(mappedId);
- if (NativeTypeSpec.INT8 != column.type().spec()) {
+ if (!isSupportedColumnTypeChange(column.type().spec().asColumnType(),
ColumnType.INT8)) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
