sashapolo commented on code in PR #3003:
URL: https://github.com/apache/ignite-3/pull/3003#discussion_r1439383557
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlApiBaseTest.java:
##########
@@ -315,28 +319,50 @@ public void checkExplicitTxRollback() {
}
/** Check correctness of rw and ro transactions for table scan. */
- @Test
- public void checkMixedTransactionsForTable() {
+ @CartesianTest(name = "roTx={0} commit={1} explicit={2}")
+ public void checkMixedTransactionsForTable(
+ @Values(booleans = {true, false}) boolean roTx,
+ @Values(booleans = {true, false}) boolean commit,
+ @Values(booleans = {true, false}) boolean explicit
+ ) {
sql("CREATE TABLE TEST(ID INT PRIMARY KEY, VAL0 INT)");
Matcher<String> planMatcher = containsTableScan("PUBLIC", "TEST");
- checkMixedTransactions(planMatcher);
+ checkMixedTransactions(planMatcher, roTx, commit, explicit);
}
/** Check correctness of rw and ro transactions for index scan. */
- @Test
- public void checkMixedTransactionsForIndex() throws Exception {
+ @CartesianTest(name = "roTx={0} commit={1} explicit={2}")
Review Comment:
Yes, but I think it's easier to understand what happens if a test fails (all
these combinations describe different tests states and IMHO should be
separated). I can revert this change, if you insist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
