rpuch commented on code in PR #3009:
URL: https://github.com/apache/ignite-3/pull/3009#discussion_r1447116217


##########
modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -434,6 +434,9 @@ public static class Network {
 
         /** Port is in use. */
         public static final int PORT_IN_USE_ERR = 
NETWORK_ERR_GROUP.registerErrorCode((short) 2);
+
+        /** Recipient node has left the physical topology. */
+        public static final int RECIPIENT_LEFT_ERR = 
NETWORK_ERR_GROUP.registerErrorCode((short) 5);

Review Comment:
   I wonder should we separate internal and public error codes by using 
different ranges? Those codes 3 and 4 are actually occupied by internal error 
codes. Holes in public error code ranges look weird.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to