ibessonov commented on code in PR #3042:
URL: https://github.com/apache/ignite-3/pull/3042#discussion_r1450500688
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java:
##########
@@ -284,16 +288,10 @@ private CompletableFuture<List<WatchAndEvents>>
collectWatchesAndEvents(List<Ent
}, watchExecutor);
}
- private CompletableFuture<Void>
invokeOnRevisionCallback(List<WatchAndEvents> watchAndEventsList, long
revision, HybridTimestamp time) {
+ private CompletableFuture<Void> invokeOnRevisionCallback(long revision,
HybridTimestamp time) {
try {
- // Only notify about entries that have been accepted by at least
one Watch.
- var acceptedEntries = new HashSet<EntryEvent>();
-
- for (WatchAndEvents watchAndEvents : watchAndEventsList) {
- acceptedEntries.addAll(watchAndEvents.events);
- }
-
- var event = new WatchEvent(acceptedEntries, revision, time);
+ // We consciously put empty set here. Revision applied callback
doesn't need any data.
Review Comment:
Ok, I'll do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
