tkalkirill commented on code in PR #3065:
URL: https://github.com/apache/ignite-3/pull/3065#discussion_r1458561986
##########
modules/network/src/main/java/org/apache/ignite/internal/network/direct/DirectMessageWriter.java:
##########
@@ -480,6 +484,9 @@ public void beforeInnerMessageWrite() {
/** {@inheritDoc} */
@Override
public void afterInnerMessageWrite(boolean finished) {
+ // Prevent leaks.
Review Comment:
```suggestion
// Prevent memory leaks.
```
##########
modules/network/src/main/java/org/apache/ignite/internal/network/direct/DirectMessageWriter.java:
##########
@@ -39,6 +40,9 @@
* Message writer implementation.
*/
public class DirectMessageWriter implements MessageWriter {
+ /** Empty array-based byte buffer. Not read-only. */
+ public static final ByteBuffer EMPTY_BUFFER =
ByteBuffer.wrap(ArrayUtils.BYTE_EMPTY_ARRAY);
Review Comment:
Suggestion: Maybe we can rename it `EMPTY_BYTE_ARRAY`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
