AMashenkov commented on code in PR #3081:
URL: https://github.com/apache/ignite-3/pull/3081#discussion_r1463149523
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##########
@@ -603,4 +603,9 @@ private static class ParentIdAwareDescriptor<T> {
this.id = id;
}
}
+
+ /** List of reserved schema names. */
+ public static List<String> reservedSchemas() {
+ return List.of(SYSTEM_SCHEMA_NAME);
+ }
Review Comment:
```suggestion
public static boolean isSystemSchema(String schemaName) {
return List.of(SYSTEM_SCHEMA_NAME).contains(schemaName);
}
```
Also, a list can be cached.
I'd moved the method to CatalogUtils or made it non-static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
