gurustron commented on code in PR #3088:
URL: https://github.com/apache/ignite-3/pull/3088#discussion_r1465451839
##########
modules/platforms/dotnet/Apache.Ignite/Internal/Metrics.cs:
##########
@@ -44,129 +44,129 @@ internal static class Metrics
/// Currently active connections.
/// </summary>
public static readonly ObservableCounter<int> ConnectionsActive =
Meter.CreateObservableCounter(
- name: "connections-active",
+ name: MetricNames.ConnectionsActive,
observeValue: () => Interlocked.CompareExchange(ref
_connectionsActive, 0, 0),
unit: "connections",
- description: "Currently active connections");
+ description: "Total number of currently active connections");
/// <summary>
/// Total number of connections established.
/// </summary>
public static readonly Counter<long> ConnectionsEstablished =
Meter.CreateCounter<long>(
- name: "connections-established",
+ name: MetricNames.ConnectionsEstablished,
unit: "connections",
description: "Total number of established connections");
/// <summary>
/// Total number of connections lost.
/// </summary>
public static readonly Counter<long> ConnectionsLost =
Meter.CreateCounter<long>(
- name: "connections-lost",
+ name: MetricNames.ConnectionsLost,
unit: "connections",
description: "Total number of lost connections");
/// <summary>
/// Total number of connections lost due to timeout.
/// </summary>
public static readonly Counter<long> ConnectionsLostTimeout =
Meter.CreateCounter<long>(
- name: "connections-lost-timeout",
+ name: MetricNames.ConnectionsLostTimeout,
unit: "connections",
description: "Total number of lost connections due to network
timeout");
/// <summary>
/// Handshakes failed.
/// </summary>
public static readonly Counter<long> HandshakesFailed =
Meter.CreateCounter<long>(
- name: "handshakes-failed",
+ name: MetricNames.HandshakesFailed,
unit: "handshakes",
description: "Total number of failed handshakes (due to version
mismatch, auth failure, etc)");
Review Comment:
`etc` -> `etc.`
##########
modules/platforms/dotnet/Apache.Ignite/Internal/Metrics.cs:
##########
@@ -44,129 +44,129 @@ internal static class Metrics
/// Currently active connections.
/// </summary>
public static readonly ObservableCounter<int> ConnectionsActive =
Meter.CreateObservableCounter(
- name: "connections-active",
+ name: MetricNames.ConnectionsActive,
observeValue: () => Interlocked.CompareExchange(ref
_connectionsActive, 0, 0),
unit: "connections",
- description: "Currently active connections");
+ description: "Total number of currently active connections");
/// <summary>
/// Total number of connections established.
/// </summary>
public static readonly Counter<long> ConnectionsEstablished =
Meter.CreateCounter<long>(
- name: "connections-established",
+ name: MetricNames.ConnectionsEstablished,
unit: "connections",
description: "Total number of established connections");
/// <summary>
/// Total number of connections lost.
/// </summary>
public static readonly Counter<long> ConnectionsLost =
Meter.CreateCounter<long>(
- name: "connections-lost",
+ name: MetricNames.ConnectionsLost,
unit: "connections",
description: "Total number of lost connections");
/// <summary>
/// Total number of connections lost due to timeout.
/// </summary>
public static readonly Counter<long> ConnectionsLostTimeout =
Meter.CreateCounter<long>(
- name: "connections-lost-timeout",
+ name: MetricNames.ConnectionsLostTimeout,
unit: "connections",
description: "Total number of lost connections due to network
timeout");
/// <summary>
/// Handshakes failed.
/// </summary>
public static readonly Counter<long> HandshakesFailed =
Meter.CreateCounter<long>(
- name: "handshakes-failed",
+ name: MetricNames.HandshakesFailed,
unit: "handshakes",
description: "Total number of failed handshakes (due to version
mismatch, auth failure, etc)");
/// <summary>
/// Handshakes failed due to a timeout.
/// </summary>
public static readonly Counter<long> HandshakesFailedTimeout =
Meter.CreateCounter<long>(
- name: "handshakes-failed-timeout",
+ name: MetricNames.HandshakesFailedTimeout,
unit: "handshakes",
- description: "Total number of failed handshakes due to network
timeout");
+ description: "Total number of failed handshakes due to a network
timeout");
/// <summary>
/// Currently active requests (request sent, waiting for response).
/// </summary>
public static readonly ObservableCounter<int> RequestsActive =
Meter.CreateObservableCounter(
- name: "requests-active",
+ name: MetricNames.RequestsActive,
observeValue: () => Interlocked.CompareExchange(ref _requestsActive,
0, 0),
unit: "requests",
- description: "Currently active requests (request sent, waiting for
response)");
+ description: "Currently active requests (requests being sent to the
socket or waiting for response)");
/// <summary>
/// Requests sent.
/// </summary>
public static readonly Counter<long> RequestsSent =
Meter.CreateCounter<long>(
- name: "requests-sent",
+ name: MetricNames.RequestsSent,
unit: "requests",
description: "Total number of requests sent");
/// <summary>
/// Requests completed (response received).
/// </summary>
public static readonly Counter<long> RequestsCompleted =
Meter.CreateCounter<long>(
- name: "requests-completed",
+ name: MetricNames.RequestsCompleted,
unit: "requests",
description: "Total number of requests completed (response received)");
/// <summary>
- /// Total number of request retries.
+ /// Total number of retried requests.
/// </summary>
public static readonly Counter<long> RequestsRetried =
Meter.CreateCounter<long>(
- name: "requests-retried",
+ name: MetricNames.RequestsRetried,
unit: "requests",
- description: "Total number of request retries");
+ description: "Total number of retried requests");
/// <summary>
/// Requests failed.
/// </summary>
public static readonly Counter<long> RequestsFailed =
Meter.CreateCounter<long>(
- name: "requests-failed",
+ name: MetricNames.RequestsFailed,
unit: "requests",
- description: "Total number of failed requests (failed to send, or
completed with error)");
+ description: "Total number of failed requests (due to failure to send,
or completed with error)");
Review Comment:
is comma required here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
