vldpyatkov commented on code in PR #3069:
URL: https://github.com/apache/ignite-3/pull/3069#discussion_r1466759041
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -1348,7 +1349,8 @@ private Publisher<BinaryRow> scan(
return replicaSvc.invoke(recipientNode, request);
},
// TODO: IGNITE-17666 Close cursor tx finish.
- (unused, fut) -> fut);
+ (commit, fut) -> onScanComplete(txId, partGroupId, fut,
recipientNode, commit)
Review Comment:
This is because this is the only method used for RO transactions.
RW transaction cursors should be closed by the RW transaction when it is
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
