vldpyatkov commented on code in PR #3092:
URL: https://github.com/apache/ignite-3/pull/3092#discussion_r1470735337


##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java:
##########
@@ -132,10 +132,7 @@ private boolean hasTxFinalizationBegun() {
     /** {@inheritDoc} */
     @Override
     protected CompletableFuture<Void> finish(boolean commit) {
-        if (hasTxFinalizationBegun()) {

Review Comment:
   In the finishing flow, we set a transaction state and then assign the 
future. Hence, we may check the state, but the future is still null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to