ptupitsyn commented on code in PR #3104:
URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1473055487
##########
modules/client/src/main/java/org/apache/ignite/internal/client/compute/ClientCompute.java:
##########
@@ -271,35 +269,15 @@ private CompletableFuture<PayloadInputChannel>
executeOnOneNode(
return ch.serviceAsync(
ClientOp.COMPUTE_EXECUTE,
w -> {
- if
(w.clientChannel().protocolContext().clusterNode().name().equals(node.name())) {
- w.out().packNil();
- } else {
- w.out().packString(node.name());
- }
-
+ packNodeNames(w.out(), nodes);
packJob(w.out(), units, jobClassName, options, args);
},
ch -> ch,
- node.name(),
+ null,
Review Comment:
Don't pass null as `preferredNode`. Let's pass random node from `nodes` to
increase the chance of local execution.
This is especially important when `nodes` has only one node and a direct
connection exists - guaranteed single network call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
